Refactor & fix switchboard join/leave tracking

mozilla / janus-plugin-sfu

Janus plugin to act as a kind of SFU for game networking data.

Mozilla Public License 2.0

135 stars 40 forks source link

Refactor & fix switchboard join/leave tracking #54

Closed mqp closed 4 years ago

mqp commented 4 years ago

WIP -- haven't tested yet. Just putting it here in case it's useful to you.

This fixes #52 and changes the switchboard data structures to be more sympathetic to how we're using them. We can now do get_publisher in constant time and kicking users also got faster. Hopefully the code also got cleaner and harder to mess up.

To do still:

[ ] Change "user" terminology to "client" to be less misleading.
[x] Tag whether a session is a publisher or a subscriber in the session state.

gfodor commented 4 years ago

I did a little load testing with this and experienced no problems. Will take a closer look at the code as well before rolling this out.

mqp commented 4 years ago

That's cool, I literally didn't run it so I'm glad it worked :-)

I will poke at it, tidy it up, and see whether I am confident in it myself tonight.

mqp commented 4 years ago

I poked at this but my improvements aren't quite fully baked yet. I am more confident in what's done so far though.

mqp commented 4 years ago

Merging this prior to further work because it seems working, in contrast to master, which is busted.

gfodor commented 4 years ago

thanks @mqp !