search

mozilla / janus-plugin-sfu

Janus plugin to act as a kind of SFU for game networking data.
Mozilla Public License 2.0
135 stars 40 forks source link

Config erroneously implies that setting 0 for max_room_size and max_ccu means no limit #56

Closed jbaicoianu closed 3 years ago

jbaicoianu commented 4 years ago

I tried setting max_ccu in janus.plugin.sfu.jcfg to 0 and was unable to connect to the server, which was returning a "Server is full" error. Expected behavior is that this would disable the limit, instead it seems a limit of 0 is enforced.

mqp commented 4 years ago

Good catch, I will fix this up.

vincentfretin commented 3 years ago

@mqp we should at least just remove the "Zero means no limit." in janus.plugin.sfu.cfg.sample or change the code to not make any check if equals 0. See also https://github.com/mozilla/janus-plugin-sfu/issues/57