search

mozilla / janus-plugin-sfu

Janus plugin to act as a kind of SFU for game networking data.
Mozilla Public License 2.0
135 stars 39 forks source link

Fix room param type #63

Closed vincentfretin closed 3 years ago

vincentfretin commented 3 years ago

Doesn't change anything because UserId and RoomId are both string, but it's better to have the right type.

vincentfretin commented 3 years ago

@mqp Can you please merge this simple change? Thanks!

mqp commented 3 years ago

Nice catch. I wish Rust newtypes didn't implicitly cast into each other like this! Maybe there's a more idiomatic way?