Remove multimap dependency

mozilla / janus-plugin-sfu

Janus plugin to act as a kind of SFU for game networking data.

Mozilla Public License 2.0

135 stars 40 forks source link

Closed mqp closed 3 years ago

mqp commented 3 years ago

This wasn't really pulling its weight, and killing it decreases the surface area for bugs like #62.

Also now we don't leak an empty vec in maps for every user and room that ever exists which is nice.

vincentfretin commented 3 years ago

Nice, the changes looks great. I'll test to build this today with my additional fix about the publisher reconnecting.

vincentfretin commented 3 years ago

I actually deployed just this branch on my server and asked everyone to do some tests. I'll let you know if there is any issue.

mqp commented 3 years ago

OK, I'll merge it if it seems like it's working well for you.

vincentfretin commented 3 years ago

My colleague did the tests with all his devices yesterday. He didn't have any weird issues, so that's cool. Yes, you can merge. Thank you very much!

vincentfretin commented 3 years ago

Still no issues. :)