search

mozilla / janus-plugin-sfu

Janus plugin to act as a kind of SFU for game networking data.
Mozilla Public License 2.0
135 stars 39 forks source link

Write some documentation about auth_key and the JWT content #77

Closed vincentfretin closed 3 years ago

vincentfretin commented 3 years ago

See my comment here https://github.com/mozilla/dialog/issues/8#issuecomment-683903134 We need to have some documentation in this repository. I'll probably do a PR here once I get to implement it in my app.

vincentfretin commented 3 years ago

FYI I updated the example in my naf-janus-adapter repo branch 3.0.x to generate a client id and set it with setClientId https://github.com/networked-aframe/naf-janus-adapter/blob/3.0.x/examples/index.html You just need to change the url to your hosted janus and the example now works. We didn't have any working example before in the naf-janus-adapter, this was unfortunate.

vincentfretin commented 3 years ago

Note removed, the content is now in the document linked in the last comment of this issue.

vincentfretin commented 3 years ago

Note removed, the content is now in the document linked in the last comment of this issue.

PlumCantaloupe commented 3 years ago

Thank you for this note. I was wondering why I couldn't get this adapter to work with an installed instance of the Janus gateway running; but I guess you need audio on for the rest of the data to stream ( I was trying to do this without streaming audio).

vincentfretin commented 3 years ago

If you didn't see it, read the janus deployment doc I wrote https://github.com/networked-aframe/naf-janus-adapter/pull/8 We can discuss on A-Frame slack if you have some issues setting it up.

PlumCantaloupe commented 3 years ago

Ah nice, didn't see that. Very helpful thank you.

vincentfretin commented 3 years ago

I removed the content of my two comments. I moved the content and rewrote some paragraphs in the documentation there https://github.com/networked-aframe/naf-janus-adapter/blob/master/docs/securing-janus-with-jwt.md