mozilla / janus-plugin-sfu

Janus plugin to act as a kind of SFU for game networking data.
Mozilla Public License 2.0
135 stars 39 forks source link

Better publisher reconnection with reclaim session #85

Open vincentfretin opened 3 years ago

vincentfretin commented 3 years ago

We discussed publisher reconnection in #73 where I ended up tuning the session_timeout parameter, but this still has a long delay of 38s before the publisher can talk again. I saw this comment on the mailing-list about session reclaim: https://groups.google.com/g/meetecho-janus/c/tPNYtfMek6s/m/hbvCGjjLAAAJ Maybe worth investigating, this would need changes in the reconnection logic in naf-janus-adapter as well.

vincentfretin commented 3 years ago

Reclaiming a session was implemented in april 2018, see relevant commits: https://github.com/meetecho/janus-gateway/compare/74f537bce4a4b3740da8ff6b09d98aa595c5a215...a53ea18a3a30f199a6f2f1cf0db91b867980b7e8

You need an value >0 for reclaim-session-timeout for sure, changes in naf-janus-adapter, maybe a change in minijanus. I'm not sure if there is a change in janus-plugin-sfu or janus-plugin-rs needed. I didn't investigate further than this.