I had an issue with naf-janus-adapter master (see issue https://github.com/networked-aframe/naf-janus-adapter/issues/21) where the js code can now triggers duplicate avatar on reconnect because of this part of the code I think because the users could possibly never receive the leave event. This is my hypothesis, I don't have proof that the leave event was not send when the issue occurred.
I currently don' plan to investigate this further, just wanted to document it. I currently reverted back to naf-janus-adapter 3.0.x in production.
I see there is currently a todo comment there https://github.com/mozilla/janus-plugin-sfu/blob/ef815ec2c23030035aaef7047db57368c1fabfca/src/lib.rs#L336-L342
I had an issue with naf-janus-adapter master (see issue https://github.com/networked-aframe/naf-janus-adapter/issues/21) where the js code can now triggers duplicate avatar on reconnect because of this part of the code I think because the users could possibly never receive the
leaveevent. This is my hypothesis, I don't have proof that theleaveevent was not send when the issue occurred.I currently don' plan to investigate this further, just wanted to document it. I currently reverted back to naf-janus-adapter 3.0.x in production.