Note for reviewers: The location of the test is debatable. I wanted to have the equivalent of a end-to-end test, to make sure we end-up receiving the details in the queue item.
Note 2: I'm not super proud of the trick that consists in replacing the args attribute with our own string, but I couldn't come up with a better idea. I thought to move the inspection code to the queue class, but we wouldn't benefit from the changes in Sentry...
Note 3: Didn't focus on Bugzilla HTTP errors since we don't raise anything when bug details / comments cannot be fetched (we have a catch all in runner). See #971
Open to revisit any choice based on your feedback 🙏
Fix #969
Note for reviewers: The location of the test is debatable. I wanted to have the equivalent of a end-to-end test, to make sure we end-up receiving the details in the queue item.
Note 2: I'm not super proud of the trick that consists in replacing the
argsattribute with our own string, but I couldn't come up with a better idea. I thought to move the inspection code to the queue class, but we wouldn't benefit from the changes in Sentry...Note 3: Didn't focus on Bugzilla HTTP errors since we don't raise anything when bug details / comments cannot be fetched (we have a catch all in runner). See #971
Open to revisit any choice based on your feedback 🙏