Closed acmiyaguchi closed 5 years ago
Oh and please feel free to ask more specific questions or tag me on small PRs
@badboy A question I forgot to ask yesterday -- do you have a suggested pattern for error handling? Where does Result
make more sense than Option
? Are there particular functions that would benefit from error handling?
In general:
Option
should be usedFor an application it would make sense to have an error type with proper user-facing formatting. A library such as failure
can ease the usage across the library.
I think most of it got reviewed by individual PRs. Is there anything I should take a look at specifically before it gets merged into master?
I don't think there's anything in particular -- this has been reviewed by you in most part.
This PR would make the main branch master, after which I'll move the repository into the mozilla organization. The largest piece I'd like to see is more robust error handling, but the code here is stable enough to plumb mozilla-pipeline-schemas into BigQuery and successfully load data.
Refactoring will be a task of its own, but hopefully the test suite here will make it easier to transition to something with a saner error-handling interface that's more configurable.