mozilla / jsonschema-transpiler

Compile JSON Schema into Avro and BigQuery schemas
Mozilla Public License 2.0
43 stars 9 forks source link

Integration test scripts #43

Closed acmiyaguchi closed 5 years ago

acmiyaguchi commented 5 years ago

This PR includes a set of integration tests used to verify the serialization of telemetry and structured ingestion against a sampled set of landfill documents. These tests require valid aws credentials (via boto3) and gcp credentials (via the gcloud cli).

Is this the appropriate repository for these scripts?

badboy commented 5 years ago

For the lack of a better repository: having them here at least makes sure we don't loose them. They don't seem relevant to the development of this specific tool directly though, so maybe eventually there's a better repository which covers the pipeline testing better?

Not gonna comment on the code (Python is not my strong suite), but please include how to run these and what to expect from them down somewhere.

acmiyaguchi commented 5 years ago

It makes sense to eventually migrate them elsewhere, but it sounds like it's fine to host them here while I figure out the best place to place them. I'll add a separate README inline with the scripts folder.