Closed jezdez closed 8 years ago
@mreid-moz r? Let me know if you want to chat a bit about the changes I've made to this. Next is trying this version of the extension on a.t.m.o
Looks good to me!
@jezdez one of the original design decisions was that the package could be installed with pip without any extra steps. Unless there is a strong reason not to, I would love for the extension to be installed with a single command like as shown here. Could you please comment on that?
@vitillo That's an understandable goal and I agree this would be preferable. I looked through a few bigger Jupyter extensions though and read the official Jupyter docs for distributing extensions as Python packages and came to the conclusion that separating the installation step from setting Jupyter config variables is the current and future best practice despite the fact that some extensions (notably those that have a history going back to the IPython community) haven't made the jump to it. I admit the community of extensions seem to be in the process to figure out more complicated configuration steps, as indicated by the relative simplicity of the activation steps. That isn't a problem for either this extension nor for jupyter-notebook-gist.
To summarize the reasons that made me separate the steps:
@jezdez That makes sense, thanks for the awesome description of the rationale!
@vitillo Thanks man, I'll keep an eye on the progress of the community a bit as well.
This requires to use the official jupyter CLI tool to enable the extension after pip-installing it instead of using a custom solution.
It enables the option to install from whl files and fixes a threadsafety issue with the Tornado handler.
This change is