mozilla / jupyter-spark

Jupyter Notebook extension for Apache Spark integration

Mozilla Public License 2.0

193 stars 34 forks source link

Bug 1286859 - Add a 'cancel' link for spark jobs #26

Closed washort closed 6 years ago

washort commented 7 years ago

See also https://github.com/mozilla/emr-bootstrap-spark/pull/110, necessary for this to work

This change is

mozilla-autolander-deprecated commented 7 years ago

Autolander could not find a bug number in your pull request title. All pull requests should be in the format of: Bug [number] - [description].

robhudson commented 7 years ago

@washort think we can get the tests to pass on this project and rebase?

codecov-io commented 7 years ago

Codecov Report

Merging #26 into master will not change coverage. The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #26   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      3           
  Lines          56     56           
  Branches        5      5           
=====================================
  Hits           56     56

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fee2d4c...5775dc8. Read the comment docs.

washort commented 7 years ago

Looks like tox-travis fixed it. r?

florian commented 7 years ago

Can this be merged? It'd be super useful and it looks like the tests now pass.

mreid-moz commented 6 years ago

@mdboom maybe this is something you could have a look at?

mdboom commented 6 years ago

Just had a look at this. I can definitely confirm it still works. A couple of thoughts:

Minor point: I think it would be good to add a little sprinkle of CSS so the cancel link looks more "clickable".
It's a shame that canceling spews a big scary Javaesque traceback at you, but looking at how this all works, I doubt it's easy to fix that. The kernel doesn't really know how or why the task was canceled, just that it was. I think we shouldn't let that hold up this PR. Maybe create a new "papercut" issue after merging this?

@washort: I'm happy to do (1) to push this over the finish line, but don't want to step on toes...

washort commented 6 years ago

Go ahead, I haven't been involved in this side of things for a while. Thanks!

mdboom commented 6 years ago

Closing. Replacing with #34.