Closed mreid-moz closed 8 years ago
@mreid-moz Could your clarify what should be tested here, the Tornado handler and its ability to replace links? The JavaScript frontend? An actual Spark job?
The link-replacing code in spark.py
would be a good start. Ideally I'd like to be able to test the proxying and frontend too. Basically looking for a way to increase confidence that changes aren't going to break things (and avoid manual verification).
@mreid-moz Great, I've started to write tests against jupyter-notebook-gist using pytest-tornado, which I think will be effective in show casing the core features of the extension as it allows running through the tornado pipeline completely
Sounds good! Thanks!
Sorry, I forgot to add the issue to the commit message. This was fixed in https://github.com/mozilla/jupyter-spark/commit/a2a04e8482682748bc3b4c0a6693f49d47181492.
Please add tests so that we can run them via Travis CI.