search

mozilla / jx-sqlite

JSON query expressions using SQLite
Mozilla Public License 2.0
35 stars 19 forks source link

Merge: Tests for using decisive ne op #52

Closed rohit-rk closed 7 years ago

klahnakoski commented 7 years ago

the tests look good

rohit-rk commented 7 years ago

I see this We can now remove this if block: The partial_eval will simplify this for us at my github new feed but can't find which if block are you talking about and can't find one, may be due to my earlier commits.

klahnakoski commented 7 years ago

Please ignore my comment "We can now remove this if block: The partial_eval will simplify this for us". It was badly planned. The partial_eval can be used to replace python code that performs expression simplification, but it fraught with problems concerning circular logic.

rohit-rk commented 7 years ago

I believe we can merge this pull request now, there's only test cases for ne op to be merged.