search

mozilla / learning.mozilla.org

This repo is for tracking initiatives of the Mozilla Learning Networks team.
https://learning.mozilla.org
Mozilla Public License 2.0
61 stars 91 forks source link

Delete stale branches #2425

Open mmmavis opened 7 years ago

mmmavis commented 7 years ago

@cadecairos @alanmoo @gvn @gideonthomas @Pomax @ScottDowne

We have tons of stale branches on this repo. If a branch belongs to you and you know it's been merged / is no longer needed can you please delete it? 👍 😄

https://github.com/mozilla/learning.mozilla.org/branches/stale

alanmoo commented 7 years ago

Looks like the last stale one is one you created @mmmavis. Safe to close this now?

mmmavis commented 7 years ago

@hannahkane can I delete the branch that we used for CMS integration experiment last year?

hannahkane commented 7 years ago

@simonwex - what do you think? ^

hannahkane commented 7 years ago

@mmmavis - i think it's likely we can delete, but I'm hesitant to say yes because I know we have more CMS work coming up shortly. @simonwex, can you please advise?

mmmavis commented 7 years ago

There's no harm to have that branch stayed a little longer. :)

That cms-enabled branch hasn't been updated in 10 months so I'm 99% sure we can safely delete it. (though a confirmation from @simonwex is still preferred 😂 )

ScottDowne commented 7 years ago

You can always reopen.

Pomax commented 7 years ago

you can't reopen a deleted branch, it gets removed from the git tree.

ScottDowne commented 7 years ago

@Pomax lol, that makes sense. I guess in my mind, it was a pull request, and not a branch. (putting all branches on master is new and weird to me, and still not sure how I feel about it.)

Pomax commented 7 years ago

What do you mean with "master"? (master is also a branch =). If you meant working form the main repo, the benefit of that is that it allows autodeploys for PRs from feature branches into the master branch. As github gives you a convenient "delete branch" button after a PR gets merged in, this type of work shouldn't pollute the repository anymore, with only the relevant changes preserved as the commits that got merged in. Anyone can of course still file PRs from other remotes, but those won't get autodeployed for testing.

ScottDowne commented 7 years ago

Yeah, meant from mozilla repo.