search

mozilla / lightbeam-we

Web Extension version of the Firefox Lightbeam add-on
https://addons.mozilla.org/en-GB/firefox/addon/lightbeam/
Mozilla Public License 2.0
179 stars 61 forks source link

Some allowlist third parties show up on the graph #179

Closed biancadanforth closed 7 years ago

biancadanforth commented 7 years ago

See this comment for an explanation.

I believe this is a related issue to #110 .

biancadanforth commented 7 years ago

Basically, youtube starts out as a first party, and later becomes an allowlisted third party (so that it's firstParty key is set to false and isVisible key is also set to false). This means when we refresh the page, getAll, which only returns nodes that are either firstParty or isVisible true, ignores youtube, so any nodes it was originally connected to in the visualization lose their youtube link.

In general, the logic of setThirdParty should be such that firstParty and isVisible should never be changed if they are ever true.

jonathanKingston commented 7 years ago

Should be fixed with latest patch.