Treat data with more consistency #177 possibly #179 and issues with #110

[jonathanKingston]

Changes include:

• Ensuring modified data that is stored gets passed back in update calls
• Inbound, outbound data munging to be the same shape (I think there are some bits missing to this)
• Ensures we draw the graph based on the thirdParties and firstParties keys rather than what type the node is
• Merges data for isVisible and firstParty so they never go from true to false after being set
• Fixes race condition where tp fires before fp causing a broken fp node.

[biancadanforth]

I see that youtube and google are first parties now even after refresh, so that's good. But this still suffers from at least a couple symptoms:

Going to:

1. https://www.google.com/search?q=dfdfdf&ie=utf-8&oe=utf-8&client=firefox-b-ab
2. https://www.youtube.com/
3. https://developers.google.com/youtube/youtube_player_demo

www.youtube.com still links to allowlisted third parties (depending on the order of requests; this is intermittent):

• s1.2mdn.net
• securepubads.g.doubleclick.net

Also refreshing the page still has the same issue of showing a completely different graph.

[jonathanKingston]

Test it again the latest update fixes the issue you mentioned.

[jonathanKingston]

Changes include:

• Ensuring stored data is passed to updates
• Inbound, outbound data munging to be the same shape (I think there are some bits missing to this)
• Ensures we draw the graph based on the thirdParties and firstParties keys rather than what type the node is
• Merges data for isVisible and firstParty so they never go from true to false after being set
• Fixes race condition where tp fires before fp causing a broken fp node.

[jonathanKingston]

There may be a race condition with populating the allow list perhaps because I can't replicate what you are saying.

I think this supercedes the pr for #110

[jonathanKingston]

Issues:

• First parties count sometimes doesn't populate for me, I will check if this causes it.
• Wikipedia.org doesn't seem to go on the graph either.
  • Update: I think this is that the capturing crashes for some reason, I can only replicate this after loading all the default new icons and a few others:
• https://www.youtube.com/
• https://planet.mozilla.org/
• https://www.google.com/
• https://wearejh.com/
• https://developers.google.com/youtube/youtube_player_demo
• https://www.reddit.com/r/woahdude/comments/6wssg9/i_combined_12_exposures_to_capture_the_suns/
• https://en.wikipedia.org/wiki/South_Dakota_School_for_the_Deaf
• https://twitter.com/
• https://www.wikipedia.org/
• https://www.facebook.com/

[biancadanforth]

Edit: This may be the first bullet point for you above re: Issues.

I don't see the capturing crashing, but I am definitely seeing that the dynamic vars aren't matching the visualization on refresh (says 'you have visited' 1 site and should be more like 10):

This happens also on the master branch, but to a lesser extent for these same sites (i.e. says 9 instead of 10, and i think the count is only off by one because youtube gets swapped to a third party on reload on the master branch).

We could make this a follow up issue.

[jonathanKingston]

Yeah just one thing to double check because I am paranoid. Will look when home.

[jonathanKingston]

Going to merge this as agreement with @biancadanforth that this solves many of the issues involved. I'm sure some might still exist to a smaller scale.