Closed jonathanKingston closed 7 years ago
I see that youtube and google are first parties now even after refresh, so that's good. But this still suffers from at least a couple symptoms:
Going to:
www.youtube.com
still links to allowlisted third parties (depending on the order of requests; this is intermittent):
Also refreshing the page still has the same issue of showing a completely different graph.
Test it again the latest update fixes the issue you mentioned.
Changes include:
There may be a race condition with populating the allow list perhaps because I can't replicate what you are saying.
I think this supercedes the pr for #110
Issues:
Edit: This may be the first bullet point for you above re: Issues.
I don't see the capturing crashing, but I am definitely seeing that the dynamic vars aren't matching the visualization on refresh (says 'you have visited' 1 site and should be more like 10):
This happens also on the master
branch, but to a lesser extent for these same sites (i.e. says 9 instead of 10, and i think the count is only off by one because youtube gets swapped to a third party on reload on the master branch).
We could make this a follow up issue.
Yeah just one thing to double check because I am paranoid. Will look when home.
Going to merge this as agreement with @biancadanforth that this solves many of the issues involved. I'm sure some might still exist to a smaller scale.
Changes include: