mozilla / lightbeam-we

Web Extension version of the Firefox Lightbeam add-on
https://addons.mozilla.org/en-GB/firefox/addon/lightbeam/
Mozilla Public License 2.0
179 stars 61 forks source link

Consider how to handle queued requests for recently closed tabs #183

Closed biancadanforth closed 7 years ago

biancadanforth commented 7 years ago

From capture.setThirdParty:

// inside capture.setThirdParty
if (this.isVisibleTab(response.tabId)) {
      const tab = await browser.tabs.get(response.tabId);
      firstPartyUrl = new URL(tab.url);
}
// ...

If the user closes a tab, and we have requests that tab previously made still in our queue, when capture tries to process these requests, we get the following error:

Error: Invalid tab ID: X where X is the closed tab's ID and X !== -1 (i.e. the tab is visible)

We should consider how to handle these requests.

jonathanKingston commented 7 years ago

Should be fixed with latest patch.