search

mozilla / lightbeam-we

Web Extension version of the Firefox Lightbeam add-on
https://addons.mozilla.org/en-GB/firefox/addon/lightbeam/
Mozilla Public License 2.0
179 stars 61 forks source link

Meaningful variable names for the reset data dialog box message #199

Closed princiya closed 6 years ago

princiya commented 7 years ago

PR #197 added a warning message before resetting data.

As per the follow-up comment in that PR, we need to have meaningful variable names for the reset data message.

Changing to meaningful variable names (rather than start and end) Do the concat in the template string (rather than having spaces in the strings): ${msgDeletion} ${msgConfirm}

Template for the message:

Image

maqboolkhan commented 6 years ago

hi is there any one working on it i want to work on it? if no one working on it im up for this

princiya commented 6 years ago

@maqboolkhan you could take this up.

maqboolkhan commented 6 years ago

ok i am up for this will do it

maqboolkhan commented 6 years ago

hi @princiya @jasonthomas i am sorry but i am unable to find PR #197 code (changes) in master branch

princiya commented 6 years ago

Sorry @maqboolkhan This has been already fixed in PR #221 here