mozilla / lightbeam-we

Web Extension version of the Firefox Lightbeam add-on

https://addons.mozilla.org/en-GB/firefox/addon/lightbeam/

Mozilla Public License 2.0

178 stars 61 forks source link

190-added-in-link-to-index #222

Closed darrylpargeter closed 6 years ago

darrylpargeter commented 6 years ago

Adds in feature requested in #190

I have added a button that takes the user from the first-run.html page to index.html

Starting State:

lightbeam_button_no_hover

Hovering State:

lightbeam_button_with_hover

jonathanKingston commented 6 years ago

Hey this looks great!

Can you change the "clicking the link below" to "using the 'Get Started' below". Then change "Click Here To Get Started" to "Get Started"

Rationale is, we should allow keyboard navigation. I'm less worried about the browser action as the primary action is clicking but if you can think of better wording to that would be great.

darrylpargeter commented 6 years ago

Hey @jonathanKingston I have update the PR with though changes.

jonathanKingston commented 6 years ago

LGTM thanks @darrylpargeter, currently we don't display this page as we didn't have the code in place to run on install vs update. So I disabled it, will raise a follow up bug.

darrylpargeter commented 6 years ago

Hey @jonathanKingston when you have created that ticket would it be possible to tackle it?