search

mozilla / lightbeam-we

Web Extension version of the Firefox Lightbeam add-on
https://addons.mozilla.org/en-GB/firefox/addon/lightbeam/
Mozilla Public License 2.0
181 stars 61 forks source link

Capture third party favicons #73

Open biancadanforth opened 7 years ago

biancadanforth commented 7 years ago

Currently, our capture script only sends first-party favicons to storage. We should also obtain third party favicon URLs if available and send it to storage.

@jonathanKingston First-party favicons were obtained through the browser.tabs.onUpdated method, which passes a tabs.Tab object to the callback function. Since third-party favicons won't be part of tab data, how would it best be obtained?

jonathanKingston commented 7 years ago

For now don't look for third party favicons. Getting on a plane now... Might be late to our meeting. see the note. Thanks

On Mon, 26 Jun 2017, 17:12 Bianca Danforth, notifications@github.com wrote:

Currently, our capture script only sends first-party favicons to storage. We should also obtain third party favicon URLs if available and send it to storage.

@jonathanKingston https://github.com/jonathankingston First-party favicons were obtained through the browser.tabs.onUpdated method, which passes a tabs.Tab object to the callback function. Since third-party favicons won't be part of tab data, how would it best be obtained?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/electrolyfish/lightbeam-we/issues/73, or mute the thread https://github.com/notifications/unsubscribe-auth/AAUsLMR-80z_1pd2lLICr9_hw1CE_gmLks5sH9hagaJpZM4OFh7p .