D3 updates - Githubissues

mozilla / lightbeam-we

Web Extension version of the Firefox Lightbeam add-on

https://addons.mozilla.org/en-GB/firefox/addon/lightbeam/

Mozilla Public License 2.0

181 stars 61 forks source link

D3 updates #97

Closed princiya closed 7 years ago

princiya commented 7 years ago

This PR has some updates to viz.js

Tries to solve #94. Although this issue wasn't a bug, graphs are improved in this PR
thirdParties are blue in color
hover state for text labels

This PR aimed to solve #76, but as per discussions, we have decided to implement it in #77.

princiya commented 7 years ago

screen shot 2017-07-10 at 22 46 49

biancadanforth commented 7 years ago

nodes_collapse @princiya Tested this; still doesn't work. The getX and getY methods return the (x,y) coordinates (width, height) if the d.x exceeds width and d.y exceeds height, causing these nodes to collapse onto each other at (width, height). Looking to see if there's a d3 solution -- or in general a way to know the bounding box dimensions (and centroid) of each subgraph and adjust? Seems overly complicated...

princiya commented 7 years ago

@jonathanKingston I have added hover state for labels in this PR. This might help @biancadanforth debug during the capture phase :)

screenshot

This doesn't solve #92, because the styling isn't complete.

jonathanKingston commented 7 years ago

Thanks @princiya!