mozilla / lightbeam-we

Web Extension version of the Firefox Lightbeam add-on
https://addons.mozilla.org/en-GB/firefox/addon/lightbeam/
Mozilla Public License 2.0
181 stars 61 forks source link

Add Disconnect Entity List (AKA whitelist). Fixes #98. #99

Closed biancadanforth closed 7 years ago

biancadanforth commented 7 years ago

This PR includes the following changes:

Youtube.com subgraph before whitelist: beforewhitelist Youtube.com subgraph after whitelist: afterwhitelist

groovecoder commented 7 years ago

Are the screenshots in the description here still accurate? It looks like many 3rd-party domains (e.g., parsely.com, cloudfront.net, __tising.com) are removed from the youtube.com graph? Those are certainly the 3rd-parties, while ytimg.com is actually 1st-party to Google. (It's the static thumbnail server for YT videos)

biancadanforth commented 7 years ago

@groovecoder ,

Are the screenshots in the description here still accurate? It looks like many 3rd-party domains (e.g., parsely.com, cloudfront.net, __tising.com) are removed from the youtube.com graph? Those are certainly the 3rd-parties, while ytimg.com is actually 1st-party to Google. (It's the static thumbnail server for YT videos)

For those specific examples, I don't see those hostnames showing up at all from any of the requests picked up by browser.onResponseStarted, so they're never getting to the whitelist check in the first place. My guess is that youtube doesn't always make the exact same requests each time the home page loads? Though I loaded the page three times and never saw any of those sites you mention (ytimg excepted).

ytimg.com is not on the Disconnect Entity List, so that's why it's not being blocked.

groovecoder commented 7 years ago

Okay yeah, I checked on my own and all the 3rd parties are definitely shown. :)

jonathanKingston commented 7 years ago

@biancadanforth as mentioned I reverted this please can you check why mozilla isn't loading third parties please. https://developer.mozilla.org/en-US/docs/Tools/Web_Console is the link I was checking.