Closed biancadanforth closed 7 years ago
Are the screenshots in the description here still accurate? It looks like many 3rd-party domains (e.g., parsely.com, cloudfront.net, __tising.com) are removed from the youtube.com graph? Those are certainly the 3rd-parties, while ytimg.com is actually 1st-party to Google. (It's the static thumbnail server for YT videos)
@groovecoder ,
Are the screenshots in the description here still accurate? It looks like many 3rd-party domains (e.g., parsely.com, cloudfront.net, __tising.com) are removed from the youtube.com graph? Those are certainly the 3rd-parties, while ytimg.com is actually 1st-party to Google. (It's the static thumbnail server for YT videos)
For those specific examples, I don't see those hostnames showing up at all from any of the requests picked up by browser.onResponseStarted
, so they're never getting to the whitelist check in the first place. My guess is that youtube doesn't always make the exact same requests each time the home page loads? Though I loaded the page three times and never saw any of those sites you mention (ytimg excepted).
ytimg.com is not on the Disconnect Entity List, so that's why it's not being blocked.
Okay yeah, I checked on my own and all the 3rd parties are definitely shown. :)
@biancadanforth as mentioned I reverted this please can you check why mozilla isn't loading third parties please. https://developer.mozilla.org/en-US/docs/Tools/Web_Console is the link I was checking.
This PR includes the following changes:
disconnect-entitylist.json
whitelist. The submodule is located in theshavar-prod-lists
subfolder in this repo's root directory.README.md
with new instructions for cloning the repo with the submodule and updating the submoduledisconnect-entitylist.json
object, parsed, intocapture.js
capture.shouldStore
method to returnfalse
if the first and third party from a request are on the whitelistobject.hasOwnProperty
to check if the first party was in the whitelist, because the whitelist hostname is a substring of the first party request hostname (ex: "youtube.com" when I have "www.youtube.com" from the request). Any thoughts on how to improve the performance of this check would be greatly appreciated..eslintignore
to ignore submoduleYoutube.com subgraph before whitelist: Youtube.com subgraph after whitelist: