Detect if history or cookies are disabled

mozilla / lightbeam

Orignal unmaintained version of the Lightbeam extension. See lightbeam-we for the new one which works in modern versions of Firefox.

https://github.com/mozilla/lightbeam-we

Mozilla Public License 2.0

587 stars 149 forks source link

Detect if history or cookies are disabled #668

Closed fmarier closed 7 years ago

fmarier commented 9 years ago

Lightbeam doesn't work when cookies are disabled (#490) or when history is disabled (#463).

We should detect these settings and show a message to the user instead of just showing a blank graph.

monicachew commented 9 years ago

The cookie thing is an easy pref check on network.cookie.cookieBehavior. It looks like history may be browser.history.allow{Push,Pop}State, or places.history.enabled. Does it fail on history because all forms of local storage are disabled?

We still get third party connections from AJAX requests, not just cookies, right? So it is possible that there will be graph data if cookies are disabled but most likely won't look like the user expects.

jonathanKingston commented 7 years ago

We now work for this case, we choose not to show cookies as fingerprinting is way more common now. (feel free to create an issue about adding it back in, the simplicity is pretty great IMO though).