search

mozilla / lightbeam

Orignal unmaintained version of the Lightbeam extension. See lightbeam-we for the new one which works in modern versions of Firefox.
https://github.com/mozilla/lightbeam-we
Mozilla Public License 2.0
587 stars 149 forks source link

Move to jpm (fixes #669) #699

Closed koenkivits closed 8 years ago

koenkivits commented 8 years ago

I don't know if this is the kind of thing you accept random pull requests for, but since I already did this for myself and there was already an issue (#669) for it I might as well just give it a try.

This commit fixes the package.json, module paths, pre-push hook and docs to be compatible with jpm. It's important to note that this raises the minimum required Firefox version from 29 to 38. On the other hand, it makes working on Lightbeam easier as the documentation is easier to find*, it has a simpler installation procedure and it deals with unsigned add-ons out of the box (just some observations from a first-time add-on developer).

(* slightly less so since #694)

fmarier commented 8 years ago

Thanks, I've been meaning to do this for a while now.