mozilla / login.webmaker.org

Login service for Webmaker.org
https://login.webmaker.org
Mozilla Public License 2.0
32 stars 62 forks source link

updates for node 6 #379

Closed Pomax closed 8 years ago

Pomax commented 8 years ago

fixes to sqlite3 and routes.js so that login can actually run on modern node (6+).

Oddly the fix in routes.js is for code that should not even work to begin with, because the env var that gets read in is a String, whereas the code pretend it's an array. Not sure why that didn't cause errors before, but it sure caused errors now =D

fixes #370, fixes #382

Pomax commented 8 years ago

@cadecairos R?

Pomax commented 8 years ago

compile errors during build fixed using the gcc solution found in https://sudogem.wordpress.com/2016/06/14/travis-ci-this-version-of-nodenanv8-requires-a-c11-compiler/

cadecairos commented 8 years ago

LGTM