mozilla / login.webmaker.org

Login service for Webmaker.org
https://login.webmaker.org
Mozilla Public License 2.0
33 stars 62 forks source link

Node update #398

Open cadecairos opened 6 years ago

cadecairos commented 6 years ago

This PR Fixes an issue with the original PR (#395) where the key that a related model was saved to got changed from older Sequelize versions.

It also contains many dependency updates to fix security issues, including changes to get the server running properly on Express 4.x

gideonthomas commented 6 years ago

let me know when this is ready for re-review @cadecairos

cadecairos commented 6 years ago

@gideonthomas will do. after many experiments I've now turned to downloading the travis-ci docker images (3.5 GB :/) so I can try to replicate the problem locally.

gideonthomas commented 6 years ago

oh dear! Ok good luck!

cadecairos commented 6 years ago

Hmm looks like it fails because of mysql