search

mozilla / makedrive

[RETIRED] Webmaker Filesystem
Mozilla Public License 2.0
351 stars 33 forks source link

Use url.href instead of url.toString() #444

Closed k88hudson closed 9 years ago

k88hudson commented 9 years ago

I ran this test case on a chrome/firefox and url.href seems to have as much support as url.toString(); resolves url.toString() not working in fxos 1.3

k88hudson commented 9 years ago

@humphd @alicoding what do you think?

humphd commented 9 years ago

Looks OK, I think. Let's try and fix later if we find it's problematic. My fear was that it wouldn't update dynamically once we changed things on the urlObject (e.g., .protocol, .pathname), but it looks like it will.

r=me. @alicoding if you're OK with this, I'll let you land and test with @k88hudson. Thanks for the patch!

alicoding commented 9 years ago

I'm okay with this and I've tested this and it's working as expected. I'm going to land this and will watch this closely to make sure nothing breaks. Thanks @k88hudson !