search

mozilla / makedrive

[RETIRED] Webmaker Filesystem
Mozilla Public License 2.0
351 stars 33 forks source link

[#448] Early return if no websockets #449

Closed k88hudson closed 9 years ago

k88hudson commented 9 years ago

I know this isn't a complete solution to what to do if no websockets exist, but it will prevent makedrive from throwing as long as the connect function isn't called and unblock us on #396

k88hudson commented 9 years ago

@humphd would you consider merging this?

gideonthomas commented 9 years ago

#396 :)

k88hudson commented 9 years ago

Oops, right.. wrong bug.

humphd commented 9 years ago

If we want to land this for mozfest and fix properly later, that's cool with me. @alicoding?

alicoding commented 9 years ago

Since this will help by at least not blocking the whole Webmaker.app front end I think we should land this and then do a real fix later on.