search

mozilla / makedrive

[RETIRED] Webmaker Filesystem
Mozilla Public License 2.0
352 stars 33 forks source link

Hiredis won't install on Windows 8.1 #476

Open sedge opened 9 years ago

sedge commented 9 years ago

I uncovered this when trying to get makedrive's tests running on a fresh install of Windows 8.1. Redis is installed and running, as are the other dependencies for makedrive.

I receive an MSBUILD error when NPM tries to insall hiredis:

MSBUILD : error MSB4132: The tools version "2.0" is unrecognized. Available tools versions are "4.0".

According to one of the redis guys, hiredis isn't officially supported on Windows to begin with.

My teammates running Windows 7 & Windows 8 (not 8.1) can install everything just fine. I found a fork purported to support windows dev: https://github.com/fuwaneko/hiredis-node

humphd commented 9 years ago

hiredis is an optional dep, so the build can fail, and things should still work. Basically, if the build succeeds, we use native C-based bindings instead of JS. If it fails, we fall back to the JS redis client code. This is how redis works internally.

Making this work on Windows isn't in scope for us, since it's a redis issue.

gideonthomas commented 9 years ago

@sedge can you confirm that everything else works without hiredis?