search

mozilla / mdv2-prototype

Prototype for the Mozilla Measurement Dashboard Version 2
https://mozilla.github.io/mdv2-prototype/
Mozilla Public License 2.0
5 stars 8 forks source link

Add plotly bar overlay chart. #49

Closed ecomerford closed 6 years ago

ecomerford commented 6 years ago

Here's the new attempt to create a comparison view in plotly. At both of your suggestion, I've used the bar chart instead of the histogram type to avoid the auto-binning. It seems like it works pretty well! I think overall, I prefer the bar version over the density areas for comparison.

screen shot 2018-08-28 at 10 29 59 pm
georgf commented 6 years ago

How does it look with barmode: "group",? I have a mild concern that if the two distributions were more-or-less the same we'd be hard-pressed to differentiate them.

We can add a separate/duplicate chart for that mode in a follow-up, then get feedback on it?

georgf commented 6 years ago

The test-failure is due to plot.ly, Chris mocked it out in #48, see here.

You can probably just rebase on the current master to get the test passing.