Selecting HTTP_SCHEME_UPGRADE_TYPE breaks the app

mozilla / mdv2-prototype

Prototype for the Mozilla Measurement Dashboard Version 2

https://mozilla.github.io/mdv2-prototype/

Mozilla Public License 2.0

5 stars 8 forks source link

Selecting HTTP_SCHEME_UPGRADE_TYPE breaks the app #57

Closed chutten closed 6 years ago

chutten commented 6 years ago

Something in the merge of #53 or #55 caused the app to break whenever you select HTTP_SCHEME_UPGRADE_TYPE. This is suboptimal.

chutten commented 6 years ago

Found the problem. The problem is when the comparison view tries to compare categorical data to GC_MS_nightly_61. I have a patch that can get us back to a working state.

chutten commented 6 years ago

Pushed it straight to master: https://github.com/mozilla/mdv2/commit/dce342ff9ef69353dd873142fad0357a70f89849

chutten commented 6 years ago

Which... was a mistake, as it error'd on build. I'll stand up a PR