search

mozilla / mdv2-prototype

Prototype for the Mozilla Measurement Dashboard Version 2
https://mozilla.github.io/mdv2-prototype/
Mozilla Public License 2.0
5 stars 8 forks source link

Comparison View: Allow comparing to things other than GC_MS nightly 61 #71

Closed chutten closed 6 years ago

chutten commented 6 years ago

In order to leave MetricData mostly alone this necessitated ComparisonView having its own copy datastore to load the comparing data and induce the view to rerender when that completed.

This involved some react hackery to store the previous state locally since the global dataStore could mutate beneath react's notice, meaning I had an infinite componentDidUpdate->loadData->setState->componentDidUpdate loop

chutten commented 6 years ago

As before, after build this should be available at https://chutten.github.io/mdv2/

Things to try: comparing GC_MS (all versions), comparing first_paint (all versions)

I hacked out the "not supported message" to try the boolean and categoricals and they render, but not very well. Wouldn't take much further effort to support them, but it's out of scope for the nonce.

Next steps: bring ComparisonView up to standard wrt hovertext and proportional units and such.