search

mozilla / memchaser

Firefox extension to chase the memory usage and garbage collector activity
https://wiki.mozilla.org/QA/Automation_Services/Projects/Addons/MemChaser
29 stars 23 forks source link

Change require statements to match the new SDK module layout and update the SDK to 1.13.2 #163

Closed KWierso closed 11 years ago

KWierso commented 11 years ago

This should let #162 work.

With this change, I no longer see the error about memory.js.

KWierso commented 11 years ago

Added the commit to update the SDK to 1.13.2 here to see if Travis likes it any better. Seems like it does.

whimboo commented 11 years ago

As discussed on IRC the only change necessary for now is the require line for local modules. So I'm going with the minimal change for Memchaser 0.5.2 and keep this pull in the backlog for 0.5.3. Once we are safe in using SDK 1.13 we can do this invasive module update.

whimboo commented 11 years ago

I would like to have this in 0.6. @KWierso would you mind updating the pull to the lastest master?

whimboo commented 11 years ago

Hi @KWierso. As I have asked 2 months ago, would you be interested to update your pull to the latest master? I would like to see this in our next 0.6 release. Thanks.

KWierso commented 11 years ago

@whimboo I'll try to get to it sometime this week, but if I don't do it this week, you might be better off just taking it over yourself.

xabolcs commented 11 years ago

Can I contribute here?

whimboo commented 11 years ago

Absolutely! I would appreciate your help here.

xabolcs commented 11 years ago

Absolutely! I would appreciate your help here.

Placeholder (only a mirror of this) pull request opened.

whimboo commented 11 years ago

Closing this pull in favor of pull #174.