search

mozilla / memchaser

Firefox extension to chase the memory usage and garbage collector activity
https://wiki.mozilla.org/QA/Automation_Services/Projects/Addons/MemChaser
29 stars 23 forks source link

Continuing #163: Change require statements and update the SDK to 1.14 #174

Closed xabolcs closed 11 years ago

xabolcs commented 11 years ago

To note for others, I'm working on this.

Not done yet, just a copy of #163.

xabolcs commented 11 years ago

In pull #163, whimboo wrote:

As discussed on IRC the only change necessary for now is the require line for local modules. So I'm going with the minimal change for Memchaser 0.5.2 and keep this pull in the backlog for 0.5.3. Once we are safe in using SDK 1.13 we can do this invasive module update.

... and:

Absolutely! I would appreciate your help here.

@whimboo, could you clarify what should I do here? For example:

xabolcs commented 11 years ago

Updated commit range, with all "require" updated.

Anything else?

xabolcs commented 11 years ago

Anything else?

For example:

xabolcs commented 11 years ago

At least for me:

whimboo commented 11 years ago

Changes to console.log behaviour in SDK 1.14

I don't think we would have to change something on this pull request. But I would suggest we add a new simple preference to the addons manager preference pane which let developers enable/disable the debug mode. Lets open another issue for it.

whimboo commented 11 years ago

Yesterday they automatically bumped us to the SDK 1.14 on AMO: https://addons.mozilla.org/en-US/firefox/addon/memchaser/versions/?page=1#version-0.5.2.1

I don't like that behavior. Especially not given that I can't find a way to opt-out anymore. :( We should get this pull finished and landed, so we can release version 0.5.3. @xabolcs will you have time the next days to update the pull?

whimboo commented 11 years ago

FYI I filed https://bugzilla.mozilla.org/show_bug.cgi?id=885273

xabolcs commented 11 years ago

@xabolcs will you have time the next days to update the pull?

Yes, I would have time in the next days.

xabolcs commented 11 years ago

... to update the pull?

Done!

whimboo commented 11 years ago

Thanks a lot! Got this landed as: https://github.com/mozilla/memchaser/commit/d1771c398c63cd1eb64af75adbf2f4b2a64bba25

xabolcs commented 11 years ago

FTR: this has been followed up in #175 and was relanded as 1268cc7080b3dee2f1837afc2fcab9083424c7bb due to incomplete merge.