search

mozilla / memchaser

Firefox extension to chase the memory usage and garbage collector activity
https://wiki.mozilla.org/QA/Automation_Services/Projects/Addons/MemChaser
29 stars 23 forks source link

Add a help item to the menu #180

Closed davehunt closed 9 years ago

davehunt commented 11 years ago

This could simply link to the README in github.

insaynasasin commented 10 years ago

Can someone please tell me what I need to do to solve the bug. I am new to open source

whimboo commented 10 years ago

Hi @insaynasasin. Thank you for your interest in fixing this issue. The first thing you should do is to actually fork this repository to your own account. Then start a new branch based of the master branch, which is used to implement the changes. For further steps it might be good if you could join us on IRC (irc.mozilla.org) in the automation channel. Would that work for you?

whimboo commented 10 years ago

@insaynasasin I haven't heard from you since August. Are you still interested to learn about open source and Javascript? If yes please let me know and I can mentor you through this issue.

whimboo commented 10 years ago

No worries. Its good to hear that you have still interest to work on this issue. If you have problems or questions once started please let us know!

insaynasasin commented 10 years ago

i forked the repo, cloned it my system and also made a new branch. Now what?

xabolcs commented 10 years ago

Please see panel.html how the existing menuitems are defined. Notice their data attributes, those actions are dispatched and handled at main.js. So your new "open a new tab with the Readme.md link" code should take place there, handling the new action came from the panel.html help menuitem.

insaynasasin commented 10 years ago

i read the panel.html and main.js. please correct me if i am wrong. i need to place a link in the panel.html page and then make appropriate changes in the main.js file so that the link opens the readme.md page and the bug will be fixed?

xabolcs commented 9 years ago

Ohh, sorry, I meant context.html in extension/data/panel/.

BTW You are right. You need to place a link in context.html as a new list element, like the other items. Then you need to write the handler of your new action in the main.js file. That should open the new tab with the Readme.md page.

If you are done with all this coding, you should push your branch to your fork in github then. After that you could open a pull request based on your feature branch against this repo's master branch.

insaynasasin commented 9 years ago

Is there a standard naming convention or can i name them as i please? Also when i try to open the already present links nothing happens. Why is it?

insaynasasin commented 9 years ago

What is the procedure of accepting pulled requests? I can see year old requests sill not getting accepted.

whimboo commented 9 years ago

Please open a PR and we will take care of. Some of the existent PRs we might wanna close because they are bitrotted and never have been updated.

Regarding the naming, I would use a simple 'Help' entry after a new separator at the end.

whimboo commented 9 years ago

I accidentally assigned it to me and I cannot reassign the issue to you until you are part of the team. I have sent you an invite. Please let me know when you have accepted it and you can assign it to yourself. Thanks.

insaynasasin commented 9 years ago

@whimboo i opened the PR some 17 hours ago so as you said, take care of it, Also i don't see any invite. kindly see to it if you have sent it or not. if yes then kindly tell me where will i find the invite?

whimboo commented 9 years ago

The invite has been sent out by Github itself. If you haven't received it please check this url and you may want to join our team? https://github.com/orgs/mozilla/teams/firefox-automation-contributor

insaynasasin commented 9 years ago

@whimboo what is the meaning of this assignment? i didn/t get it. what did you do?

whimboo commented 9 years ago

The assignment reflects that you are marked as the one who is working on this issue. It's clear for others now that this issue is covered. I will do the review of your PR in a bit.

xabolcs commented 9 years ago

Fixed by PR #220 and commit 62087d2291f7dfd5403287660bf4fe37e40925e8.