search

mozilla / memchaser

Firefox extension to chase the memory usage and garbage collector activity
https://wiki.mozilla.org/QA/Automation_Services/Projects/Addons/MemChaser
29 stars 23 forks source link

Support incremental cycle collection statistics (#187) #188

Closed xabolcs closed 10 years ago

xabolcs commented 10 years ago

A fix for #187.

It contains a minimal re-factor also.

amccreight commented 10 years ago

The analysis sounds right to me. One thing to note is that an "incremental CC" can end up only taking a single chunk of time, if it is fairly fast. I expect that to be the common case. Also, even when the pref is set, various things can force a CC, which will end up being non-incremental.

whimboo commented 10 years ago

So the above checks would catch those scenarios then or do we have to advance them?

amccreight commented 10 years ago

I'm not sure exactly what you are doing with the isIncremental check, but I think for any reasonable scenario, it is okay to treat a short CC that only took one slice as being non-incremental. It looks okay to me.

whimboo commented 10 years ago

We have this method to decide what to show in the ui. If it is CC or iCC. Similar to the garbage collector which shows GC vs. iGC.

So thanks for your feedback. I will check the patch again tomorrow, and if all is fine I will get it landed.

whimboo commented 10 years ago

Merged as https://github.com/mozilla/memchaser/commit/bcec4fe986146a03e27d7ffc20ad9f4ecf1986b1