Closed xabolcs closed 9 years ago
Added releases to build matrix:
Oh, now I see I missed aurora/dev edition.
@whimboo! mozdownload
isn't capable to download Aurora. For --type=daily
type it doesn't accept extra --release
parameter, so it downloads Nightly.
Could this PR land without Aurora?
You will have to add --branch=mozilla-aurora
to get the latest build of this branch.
Thanks for the hint! Travis build of commit 496c60b7623b2b356a4f43ccf7091587b2210447 has nice error messages.
Looks like there is a bug in the JSON API in Firefox 31.4. Might be worth having a look at, but I suspect that it will be fixed in a ESR release. If we cannot disable the test for this version, we might drop support for testing this ESR release at all.
The other failures seem like that we should get them fixed. Those might be a race-condition. Are you able to see those locally?
If we cannot disable the test for this version, we might drop support for testing this ESR release at all.
As you can see mozdownload
downloads the latest-esr
, so nothing specifically. Should I comment out that for now, and uncomment it later, when the next ESR comes out?
The other failures seem like that we should get them fixed. Those might be a race-condition. Are you able to see those locally?
I will give it a shot later tonight.
If we cannot disable the test for this version, we might drop support for testing this ESR release at all.
As you can see |mozdownload| downloads the |latest-esr|, so nothing specifically. Should I comment out that for now, and uncomment it later, when the next ESR comes out?
Sounds like a good approach. Lets do it.
The other failures seem like that we should get them fixed. Those might be a race-condition. Are you able to see those locally?
I will give it a shot later tonight.
Thanks a lot! Let me know if you have questions.
In the mean time could I file an issue to sort the .travis.yml
regarding to the build lifecycle?
Don't we follow that order? So yeah, we should get this fixed.
OK, I tested both, and I think they are something like race-condition. Something is wrong with the log test.
For example, I got new type of fail under Aurora. See below!
test:
[exec] Welcome to the Add-on SDK. For the docs, visit https://addons.mozilla.org/en-US/developers/docs/sdk/latest/
[exec] Using binary at '/home/szab/firefox/firefox'.
[exec]
[exec] (process:13460): GLib-CRITICAL **: g_slice_set_config: assertion 'sys_page_size == 0' failed
[exec] Using profile at '/tmp/tmpNxtUS1.mozrunner'.
[exec]
[exec] (process:13463): GLib-CRITICAL **: g_slice_set_config: assertion 'sys_page_size == 0' failed
[exec] Running tests on Firefox 37.0a2/Gecko 37.0a2 ({ec8030f7-c20a-464f-9b0e-13a3a9e97384}) under linux/x86_64.
[exec] .......console.error: memchaser:
[exec] fail:
[exec] 2 != 3
[exec] console.trace: memchaser:
[exec] _ecated/unit-test.js 102 fail
[exec] _ecated/unit-test.js 204 assertEqual
[exec] _ests/test-logger.js 96 exports.test_start_directory_change_nsIFile/<
[exec] _ests/test-logger.js 33 verifyAsyncOutput/<
[exec] _haser/lib/logger.js 126 Logger_writeAsync/<
[exec] _modules/NetUtil.jsm 71 NetUtil_asyncCopy/observer.onStopRequest
[exec] 0
[exec]
[exec] ..JavaScript error: resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///tmp/tmpNxtUS1.mozrunner/extensions/memchaser@quality.mozilla.org.xpi!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://memchaser-at-quality-dot-mozilla-dot-org/memchaser/tests/test-logger.js, line 99: TypeError: message[2] is undefined
[exec] console.log: memchaser: [JavaScript Error: "TypeError: message[2] is undefined" {file: "resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///tmp/tmpNxtUS1.mozrunner/extensions/memchaser@quality.mozilla.org.xpi!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://memchaser-at-quality-dot-mozilla-dot-org/memchaser/tests/test-logger.js" line: 99}]
[exec] console.error: memchaser:
[exec] fail:
[exec] Timed out (after: a == b == 60)
[exec] .........
[exec] 18 of 20 tests passed.
[exec] Total time: 5.111820 seconds
[exec] Program terminated unsuccessfully.
Hmm, it's time to add back IRC notifications. :)
I would then propose to file a new issue for this test if it is instable. Otherwise is this PR ready for review?
I would then propose to file a new issue for this test if it is instable.
Filed #208.
Otherwise is this PR ready for review?
Yes it is.
There is a pip
warning in the build log.
The directory '/home/travis/.cache/pip/log' or its parent directory is not owned by the current user and the debug log has been disabled. Please check the permissions and owner of that directory. If executing pip with sudo, you may want the -H flag.
I choose sudo
because pip install
had problems without it.
All looks great. Thanks @xabolcs!
Please squash the commits and get it landed.
Thanks! Please give me a commit message to land with!
I think, I don't have write access to this repository.
For a proper commit message please see the updated summary of issue #191. I will hand you commit access in a bit.
Thanks for both.
Landed as 4a1cada77f7718b4cd15cae832d7824bc8d5fc50.
Fix for #191.