search

mozilla / memchaser

Firefox extension to chase the memory usage and garbage collector activity
https://wiki.mozilla.org/QA/Automation_Services/Projects/Addons/MemChaser
29 stars 23 forks source link

test-logger.js has unstable results #208

Closed xabolcs closed 9 years ago

xabolcs commented 9 years ago

For example see Travis CI builds for PR #206:

xabolcs commented 9 years ago

Nice! Latest build has full of test-logger.js error.

xabolcs commented 9 years ago

What a surprise! Logger._writeAsync isn't a FIFO. See pastebin!

xabolcs commented 9 years ago

I think rewriting logger.js and test-logger.js to use promises (and sdk/io/text-streams or OS.File) is the way here.

xabolcs commented 9 years ago

Thankfully OS.File's write use FIFO!

xabolcs commented 9 years ago

So I have an OS.File based fix, for ESR31 also! :)

whimboo commented 9 years ago

Sounds good. Does it mean we need a fix in the code of memchaser or only this test?

xabolcs commented 9 years ago

I modified Logger.prototype._writeAsync, and added a new test test_high_speed_logging.

I propose a change to build.xml (and for travis.yml). It would be nice if Travis CI would have detailed test output: it would be nice to change build.xml's test target to use --verbose parameter for cfx if runs under Travis CI. A new build parameter (like -Dbinary is now) would be nice. It would help for local testing too. Thoughts?

whimboo commented 9 years ago

I would always enable verbose logging for cfx test, but we could make it opt-in for cfx run and similar commands.

xabolcs commented 9 years ago

I would ...

Filed as #209. Thanks for accepting.

xabolcs commented 9 years ago

So I have an OS.File based fix, for ESR31 also! :)

Now it works with 24.8.1 too. :)

xabolcs commented 9 years ago

Fixed by commit 45fd7accf66835762f1ef92470e9a5f1e8370980.