search

mozilla / memchaser

Firefox extension to chase the memory usage and garbage collector activity
https://wiki.mozilla.org/QA/Automation_Services/Projects/Addons/MemChaser
29 stars 23 forks source link

Travis CI build errored - mozdownload failed with AttributeError: 'module' object has no attribute 'getLogger' #234

Closed xabolcs closed 8 years ago

xabolcs commented 8 years ago

Latest CI build didn't failed, but errored.

$ mozdownload $MOZDOWNLOADPARAMS
Traceback (most recent call last):
  File "/usr/local/bin/mozdownload", line 9, in <module>
    load_entry_point('mozdownload==1.12', 'console_scripts', 'mozdownload')()
  File "/usr/local/lib/python2.7/dist-packages/mozdownload/scraper.py", line 1067, in cli
    build = BUILD_TYPES[options.type](**kwargs)
  File "/usr/local/lib/python2.7/dist-packages/mozdownload/scraper.py", line 566, in __init__
    Scraper.__init__(self, *args, **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/mozdownload/scraper.py", line 118, in __init__
    self.logger = mozlog.getLogger(' ')
AttributeError: 'module' object has no attribute 'getLogger'
The command "mozdownload $MOZDOWNLOADPARAMS" failed and exited with 1 during .
Your build has been stopped.

While I'm was there, Travis CI told me that:

This job ran on our legacy infrastructure. Please read our docs on how to upgrade

Before debugging any Python here, how about migrating to the new infrastructure (in a separate Issue)?

Cc: @whimboo

whimboo commented 8 years ago

This is mozdownload and not memchaser, right? I think you want to file this issue on the other repository. :) Btw, the container based infrastructure is easy to do and has a lot of benefits. We already did that for firefox-ui-tests. But yes, this will be a separate issue.

xabolcs commented 8 years ago

This is mozdownload and not memchaser, right?

The Travis build for MemChaser errored. Of course, something gone wrong with mozdownload.

So at least a mozdownload version bump needed for MemChaser.

whimboo commented 8 years ago

Oh! Totally! I see its using version 1.12! Wow... But we have to wait for https://github.com/mozilla/mozdownload/issues/331.

xabolcs commented 8 years ago

[...] But yes, this will be a separate issue.

Issue #235 was filed.

xabolcs commented 8 years ago

For the mozdownload update should I stick to 1.18.1 as previously did?

whimboo commented 8 years ago

Given that this is for testing with Travis only, I wouldn't mind to be loosely in the version. I would say just depend on mozdownload without any version specified. That would reduce the amount of version bumps in the future.

xabolcs commented 8 years ago

Thanks!

Taking care of it.

xabolcs commented 8 years ago

Fixed by commit ab100c59e1061d2a717cb13d632794609b274a54!