mozilla / mentat

UNMAINTAINED A persistent, relational store inspired by Datomic and DataScript.
https://mozilla.github.io/mentat/
Apache License 2.0
1.65k stars 115 forks source link

[edn] Don't unwrap when creating values while parsing EDN #230

Open victorporof opened 7 years ago

victorporof commented 7 years ago

E.g. https://github.com/mozilla/mentat/blob/ab041291fb1d806fc1e9c09ecac4a931289bd38f/edn/src/edn.rustpeg#L45 and in a few other places.

Panicking the entire thread while parsing is probably a bad idea? This would be easily recoverable and a good place to add syntax check info.

rnewman commented 7 years ago

I agree, but this is as good a place as any to note three observations:

Death, alas, is a part of life.