search

mozilla / mentat

UNMAINTAINED A persistent, relational store inspired by Datomic and DataScript.
https://mozilla.github.io/mentat/
Apache License 2.0
1.65k stars 115 forks source link

Use failure instead of error_chain #730

Closed grigoryk closed 6 years ago

grigoryk commented 6 years ago

This is an early WIP to get feedback.

So far the only non-mechanical bit was conversion of InvalidBinding, since it wraps a BindingError.

Eventually fixes #586.

grigoryk commented 6 years ago

This is bulk of the work. Needs another cleanup pass, and rebasing on top of master - query-parser is gone, algebrizer changed a bit, and #736 is about to land.

grigoryk commented 6 years ago

Tests pass! I'm not super happy with how parts of this turned out, but it's not a good idea to let this fall behind the other work. We can iterate on the particulars once/if we hit problems along the line.

grigoryk commented 6 years ago

@ncalexan do you mind giving this a lookover before I have to rebase it again? :sob: