[cli] cli broken with "No option 'key' defined"

mozilla / mentat

UNMAINTAINED A persistent, relational store inspired by Datomic and DataScript.

https://mozilla.github.io/mentat/

Apache License 2.0

1.65k stars 115 forks source link

[cli] cli broken with "No option 'key' defined" #752

Closed maweki closed 6 years ago

maweki commented 6 years ago

It seems the cli is broken since a few commits.

The error I get running echo .exit | cargo cli is thread 'main' panicked at 'No option 'key' defined', /home/maweki/.cargo/registry/src/github.com-1ecc6299db9ec823/getopts-0.2.17/src/lib.rs:767:21

I used git bisect and identified commit 6a1a2658942b29f as the first one where that happens.

ncalexan commented 6 years ago

I've addressed this locally, and will push a fix for you to test. Thanks for filing!

ncalexan commented 6 years ago

I've addressed this locally, and will push a fix for you to test. Thanks for filing!

@maweki could you cherry-pick https://github.com/ncalexan/mentat/commit/0e6e58edea38409f525164cad28a620d88378cc8 and verify that it fixes the issue for you? If you could push back a PR for merging that I would appreciate -- my local tree is in the middle of other work.

maweki commented 6 years ago

@ncalexan yes, this works. A Pull-request is attached (#753)

maweki commented 6 years ago

Since #753 is merged, this issue is superseded