search

mozilla / mentat

UNMAINTAINED A persistent, relational store inspired by Datomic and DataScript.
https://mozilla.github.io/mentat/
Apache License 2.0
1.65k stars 115 forks source link

Convert code base to Error/ErrorKind pattern #769

Open ncalexan opened 6 years ago

ncalexan commented 6 years ago

730 did heroic work to convert from error-chain to failure, but our initial consumer (a logins API that consumes Mentat and is in turn consumed by applications like Mozilla Lockbox) is finding that returning failure::Error isn't very helpful. It looks like we'll need to adopt the Error/ErrorKind pattern from https://github.com/withoutboats/failure/blob/868273409c826755812dbff1b67cc0ac3fa702f7/book/src/error-errorkind.md.

ncalexan commented 6 years ago

@grigoryk I think we talked about this, but clearly I didn't understand the full context of what's involved. I see TODO items in the code to do this work in some places; do you have a strong opinion about this approach?