search

mozilla / metric-hub

Central hub for metric definitions that are considered the source of truth
https://mozilla.github.io/metric-hub
Mozilla Public License 2.0
13 stars 13 forks source link

Add cpu exception metric #400

Closed OrlaM closed 5 months ago

OrlaM commented 5 months ago

Adding the cpu-exception metric to the firefox-ios-health dashboard.

OrlaM commented 5 months ago

@edugfilho I'm finally getting around to adding some more metrics to this thing. Let me know if this looks correct. I don't have access to GCP to run in the test environment to verify. 🙏

edugfilho commented 5 months ago

This looks good to me!

edugfilho commented 5 months ago

Auto approve / Auto approve PR if no metrics definitions changed (pull_request) failed with 

POST /repos/mozilla/metric-hub/pulls/400/reviews - 403 in 153ms
RequestError [HttpError]: Resource not accessible by integration```

@scholtzan do you know what's happening here?

scholtzan commented 5 months ago

It's coming from a fork, so a review by a human is required

edugfilho commented 5 months ago

thank you!