mozilla / metric-hub

Central hub for metric definitions that are considered the source of truth
https://mozilla.github.io/metric-hub
Mozilla Public License 2.0
10 stars 12 forks source link

[MRG] Create fakespot-in-suggest.toml #486

Closed teonbrooks closed 1 month ago

teonbrooks commented 2 months ago

First draft of the metrics needed for the fakespot experiment.

teonbrooks commented 1 month ago

@rebecca-burwei, thanks for the review. I updated the admarketplace to simplify and keep the business logic in the udf. I added a response to your followup comment on the fakespot-related suggestion. unfortunately, I think that it would require more work to add it to the udf given that it is an experimental feature so I think it makes sense to leave it in the experiment config until the feature has graduated (if that's the conclusion from the experiment)

rebecca-burwei commented 1 month ago

I think the validate-jetstream error is because there are 2 metrics called fakespot_amazon_ctr in lines 75 and 138

teonbrooks commented 1 month ago

good catch. ended up being an error in all the impression rate definitions. it was a copy-paste error