search

mozilla / metric-hub

Central hub for metric definitions that are considered the source of truth
https://mozilla.github.io/metric-hub
Mozilla Public License 2.0
10 stars 12 forks source link

update client-level DAU definitions #526

Closed bochocki closed 1 month ago

bochocki commented 1 month ago

Adds client-level DAU definitions for each product as requested in DS-3752.

danielkberry commented 1 month ago

Thanks for adding these new definitions. Are we going to make a separate PR to update the experiment guardrails to point to these?

bochocki commented 1 month ago

Thanks for adding these new definitions. Are we going to make a separate PR to update the experiment guardrails to point to these?

That sounds reasonable to me. I'm not familiar with how the experiment guardrails are implemented and wouldn't know how to update them. The concerns are separate enough that having two PRs seems sensible.

bochocki commented 1 month ago

I guess one NIT is how consistent we want to be using deprecated=false (which is the default, of course). I'm not sure what best practice is here, but I think it's fine as is?

I'm not sure I follow. I think I've set deprecated = false for all the metrics and updated deprecated = true where applicable, but please lmk if I'm missing something.

Maybe you're noting that the data_sources don't have a deprecation flag; I didn't use the field there because I assumed it wasn't a valid field on the data_sources: It's not described in the docs (here, I think) and I didn't see it used on another data_source. If it can be used it does seem useful to include and I'd be happy to add it. I'll check in #data-help.