Open TDA opened 9 years ago
This code is from the mozilla/fxa-auth-server repo and uses their styleguide for semicolons and spaces, etc.
So you could submit a PR for the bonus semicolon on line 11, but apart from that I wouldn't lose any sleep over the other stylistic issues.
Feel free to submit a PR, but I don't think I'd add the Grunt/Gulp/Travis/ESLint overhead of linting to this repo for the one file that will probably not be updated lots in the future.
but.. but... what about the if..else? thats not followed consistently :(
PRs are still welcome for this issue :-)
@6a68 ON IT!!!!! :D :D :D
We need to fix the spacing on some lines: https://github.com/mozilla/micro-email-validator/blob/master/index.js#L15 https://github.com/mozilla/micro-email-validator/blob/master/index.js#L33
Also, inconsistent indentation on: https://github.com/mozilla/micro-email-validator/blob/master/index.js#L49 https://github.com/mozilla/micro-email-validator/blob/master/index.js#L54
Also, inconsistent use of semi-colons: https://github.com/mozilla/micro-email-validator/blob/master/index.js#L11
It would be even better if we can add linting to this repo. Tagging @pdehaan for advice.