Add check for ping during postgresql connection

pwnbus commented 6 years ago

This improves troubleshooting, or else the connection seems to be established, but realistically, no connection attempt was made, the open() function only checks syntax of the db string.

jvehent commented 6 years ago

I'd recommend doing a 'SELECT 1' instead of using Ping, it's a more accurate test as it actually verifies that you're able to run queries.

On Tue, Sep 18, 2018, 19:41 Brandon Myers notifications@github.com wrote:

This improves troubleshooting, or else the connection seems to be established, but realistically, no connection attempt was made, the open() function only checks syntax of the db string.

You can view, comment on, or merge this pull request online at:

https://github.com/mozilla/mig/pull/468 Commit Summary

Check for ping when connecting to postgresql db

Add text stating trying to connect to db for feedback

File Changes

M database/database.go https://github.com/mozilla/mig/pull/468/files#diff-0 (4)

M mig-api/context.go https://github.com/mozilla/mig/pull/468/files#diff-1 (2)

M mig-scheduler/context.go https://github.com/mozilla/mig/pull/468/files#diff-2 (1)

Patch Links:

https://github.com/mozilla/mig/pull/468.patch

https://github.com/mozilla/mig/pull/468.diff

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/mozilla/mig/pull/468, or mute the thread https://github.com/notifications/unsubscribe-auth/AAZXgYwUYiJH6PcFLpecklatCRzfWodjks5ucYS9gaJpZM4WvJGO .

pwnbus commented 6 years ago

@jvehent Updated to use SELECT 1 instead of Ping.

mozilla / mig

Add check for ping during postgresql connection #468

This improves troubleshooting, or else the connection seems to be established, but realistically, no connection attempt was made, the open() function only checks syntax of the db string.