Closed arcrose closed 5 years ago
That’s weird - I would have expected it to apply the same elsewhere. Oh well!
On Fri, Oct 19, 2018 at 10:59 Zack Mullaly notifications@github.com wrote:
@zsck commented on this pull request.
In runner-plugins/runner-scribe/main.go https://github.com/mozilla/mig/pull/471#discussion_r226731763:
@@ -85,7 +86,10 @@ func main() { }
func sendVulnerability(item gozdef.VulnEvent) (err error) {
- ac := gozdef.APIConf{URL: conf.MozDef.URL}
- ac := gozdef.APIConf{
This is the format enforced by gofmt.
— You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/mozilla/mig/pull/471#discussion_r226731763, or mute the thread https://github.com/notifications/unsubscribe-auth/AAFqDKCAnodGoqF-rNzSVaJX31WT2A-Lks5umhHVgaJpZM4XxHDS .
I suspect that what's happening is my vim-go
plugin is only formatting the code I changed, which in this case is kind of nice. I could rip through everything and format all our code, but that's not really my goal here.
No worries!
On Fri, Oct 19, 2018 at 11:06 Zack Mullaly notifications@github.com wrote:
I suspect that what's happening is my vim-go plugin is only formatting the code I changed, which in this case is kind of nice. I could rip through everything and format all our code, but that's not really my goal here.
— You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/mozilla/mig/pull/471#issuecomment-431449487, or mute the thread https://github.com/notifications/unsubscribe-auth/AAFqDAFg9OtJcRt-0lM5fFtZCfHrgQN2ks5umhSpgaJpZM4XxHDS .
~This PR is dependent on the oustanding PR for gozdef to add support to disable the use of a proxy in Gozdef.~
Julien has stated that he no longer intends to maintain gozdef, so I guess I'm inheriting it. I've forked it to
mozilla/gozdef
and pushed my changes right into master.